Add a secure NPM configuration#203
Merged
Merged
Conversation
joshmgross
commented
Jun 1, 2026
| "pretest": "npm run build", | ||
| "test": "jest", | ||
| "version": "echo \"export const Version = '$npm_package_version'\" > src/version.ts && git add src/version.ts && npm run build", | ||
| "prepublishOnly": "npm run build" |
Contributor
Author
There was a problem hiding this comment.
Our publish workflow already calls npm run build
database-js/.github/workflows/publish.yml
Lines 25 to 27 in 65d1caf
mattrobenolt
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up a
.npmrcto require a minimum release age of 3 days for dependencies, disallow git dependencies, and ignore lifecycle scripts.Disabling scripts is intended to prevent malicious postinstall scripts, but it has the side-effect of disabling existing defined lifecycle scripts in our own
package.json. Those have been manually replaced with the equivalent script calls.